chore: prepare tokio 1.0.1 release #3347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carllerche
approved these changes
Dec 25, 2020
scottlamb
added a commit
to scottlamb/http-serve
that referenced
this pull request
Jan 10, 2021
tokio 1.0.0 was yanked due to a soundness hole. tokio-rs/tokio#3347
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.0.1 (December 25, 2020)
This release fixes a soundness hole caused by the combination of
RwLockWriteGuard::mapandRwLockWriteGuard::downgradeby removing themapfunction. This is a breaking change, but breaking changes are allowed under our semver policy when they are required to fix a soundness hole. (See this RFC for more.)Note that we have chosen not to do a deprecation cycle or similar because Tokio 1.0.0 was released two days ago, and therefore the impact should be minimal.
Due to the soundness hole, we have also yanked Tokio version 1.0.0.
Removed
RwLockWriteGuard::mapandRwLockWriteGuard::try_map(sync: remove RwLockWriteGuard::map and RwLockWriteGuard::try_map #3345)Fixed